From fa09b1f3d483afc9f5232f734db1f1e8626e068a Mon Sep 17 00:00:00 2001 From: Wouter Deconinck Date: Mon, 20 Apr 2020 11:19:09 -0500 Subject: [PATCH] =?UTF-8?q?Fix=20unused=20parameter=20=E2=80=98pArray?= =?UTF-8?q?=E2=80=99=20in=20mz=5Fzip=5Farray=5Frange=5Fcheck?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When NDEBUG, the assert in mz_zip_array_range_check does nothing and an unused variable warning is generated at https://github.com/richgel999/miniz/blob/4159f8c8c3d91a76648107ce6adf54bb6f06e3a7/miniz_zip.c#L280 This commit removes the `|| define (NDEBUG)` so when debugging is turned off, no range check is performed. --- miniz_zip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/miniz_zip.c b/miniz_zip.c index 5ae3193..064d448 100644 --- a/miniz_zip.c +++ b/miniz_zip.c @@ -277,7 +277,7 @@ struct mz_zip_internal_state_tag #define MZ_ZIP_ARRAY_SET_ELEMENT_SIZE(array_ptr, element_size) (array_ptr)->m_element_size = element_size -#if defined(DEBUG) || defined(_DEBUG) || defined(NDEBUG) +#if defined(DEBUG) || defined(_DEBUG) static MZ_FORCEINLINE mz_uint mz_zip_array_range_check(const mz_zip_array *pArray, mz_uint index) { MZ_ASSERT(index < pArray->m_size);