github-mirrors/thirdparty-littlefs
1
0
Fork 0
mirror of https://github.com/eledio-devices/thirdparty-littlefs.git synced 2025-10-31 00:32:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fixed issue with creating files named "littlefs"

Browse Source 
A rather humorous issue, we accidentally ended up mixing our file
namespace with our superblocks. This meant if we created a file named
"littlefs" it would reference the superblock and all sorts of things
would break.

Fixing this also highlighted another issue, the fact that the superblock
always needs to come before any file entries in the directory. I didn't
account for this in the initial B-tree design, but we need a higher
ordering for superblocks + children + files than just name. To fix this
I added ordering information in the 2 bits currently unused in the tag
type. Though note that the size of these fields are flexible.

9-bit type field:
[---      9      ---]
[1|- 3 -|- 2 -|- 3 -]
 ^   ^     ^     ^- type-specific info
 |   |     \------- ordering info
 |   \------------- subtype
 \----------------- user bit
This commit is contained in:
Christopher Haster
2018-10-04 16:25:19 -05:00
parent aeca7667b3
commit 97a7191814
4 changed files with 50 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lfs.h
View File

@@ -88,12 +88,12 @@ enum lfs_error {
// File types
enum lfs_type {
// file types
LFS_TYPE_REG = 0x002,
LFS_TYPE_DIR = 0x003,
LFS_TYPE_REG = 0x011,
LFS_TYPE_DIR = 0x010,
// internally used types
LFS_TYPE_USERATTR = 0x100,
LFS_TYPE_NAME = 0x000,
LFS_TYPE_CREATE = 0x000,
LFS_TYPE_DELETE = 0x020,
LFS_TYPE_STRUCT = 0x040,
LFS_TYPE_TAIL = 0x080,
@@ -110,8 +110,8 @@ enum lfs_type {
// internal chip sources
LFS_FROM_MEM = 0x000,
LFS_FROM_DISK = 0x200,
LFS_FROM_MOVE = 0x0c1,
LFS_FROM_USERATTRS = 0x0c2,
LFS_FROM_MOVE = 0x061,
LFS_FROM_USERATTRS = 0x062,
};
// File open flags
@@ -339,9 +339,7 @@ typedef struct lfs_file {
} lfs_file_t;
typedef struct lfs_superblock {
char magic[8];
uint32_t version;
lfs_size_t block_size;
lfs_size_t block_count;