github-mirrors/thirdparty-littlefs
1
0
Fork 0
mirror of https://github.com/eledio-devices/thirdparty-littlefs.git synced 2025-10-31 00:32:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Reduced lfs_dir_traverse's explicit stack to 3 frames

Browse Source 
This is possible thanks to invoxiaamo's optimization of compacting
renames to avoid the O(n^3) nested filters. Not only does this
significantly reduce the runtime cost of that operation, but it
reduces the maximum possible depth of recursion to 3 frames.

Deepest lfs_dir_traverse before:

traverse with commit
'-> traverse with filter
    '-> traverse with move
        '-> traverse with filter

Deepest lfs_dir_traverse after:

traverse with commit
'-> traverse with move
    '-> traverse with filter
This commit is contained in:
Christopher Haster
2022-04-10 23:24:11 -05:00
parent c60c977c25
commit abbfe8e92e
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
lfs.c
View File

@@ -767,11 +767,10 @@ static int lfs_dir_traverse_filter(void *p,
// maximum recursive depth of lfs_dir_traverse, the deepest call: // maximum recursive depth of lfs_dir_traverse, the deepest call:
// //
// traverse with commit // traverse with commit
// '-> traverse with filter // '-> traverse with move
// '-> traverse with move // '-> traverse with filter
// ' traverse with filter
// //
#define LFS_DIR_TRAVERSE_DEPTH 4 #define LFS_DIR_TRAVERSE_DEPTH 3
struct lfs_dir_traverse { struct lfs_dir_traverse {
const lfs_mdir_t *dir; const lfs_mdir_t *dir;