github-mirrors/thirdparty-littlefs
1
0
Fork 0
mirror of https://github.com/eledio-devices/thirdparty-littlefs.git synced 2025-10-31 00:32:38 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix for issue #260

Browse Source 
Certain functions within lfs_emubd.c were susceptible to file resource leaks due to certain code paths not issuing an fclose() before returning.
This commit is contained in:
Patrick Servello
2019-08-31 20:47:26 -05:00
parent 494dd6673d
commit d5aba27d60
1 changed files with 11 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
emubd/lfs_emubd.c
View File

@@ -102,6 +102,7 @@ int lfs_emubd_create(const struct lfs_config *cfg, const char *path) {
if (res < 1) { if (res < 1) {
err = -errno; err = -errno;
LFS_TRACE("lfs_emubd_create -> %"PRId32, err); LFS_TRACE("lfs_emubd_create -> %"PRId32, err);
fclose(f);
return err; return err;
} }
@@ -124,6 +125,7 @@ int lfs_emubd_create(const struct lfs_config *cfg, const char *path) {
if (res < 1) { if (res < 1) {
err = -errno; err = -errno;
LFS_TRACE("lfs_emubd_create -> %"PRId32, err); LFS_TRACE("lfs_emubd_create -> %"PRId32, err);
fclose(f);
return err; return err;
} }
@@ -178,6 +180,7 @@ int lfs_emubd_read(const struct lfs_config *cfg, lfs_block_t block,
if (err) { if (err) {
err = -errno; err = -errno;
LFS_TRACE("lfs_emubd_read -> %d", err); LFS_TRACE("lfs_emubd_read -> %d", err);
fclose(f);
return err; return err;
} }
@@ -185,6 +188,7 @@ int lfs_emubd_read(const struct lfs_config *cfg, lfs_block_t block,
if (res < size && !feof(f)) { if (res < size && !feof(f)) {
err = -errno; err = -errno;
LFS_TRACE("lfs_emubd_read -> %d", err); LFS_TRACE("lfs_emubd_read -> %d", err);
fclose(f);
return err; return err;
} }
@@ -230,6 +234,7 @@ int lfs_emubd_prog(const struct lfs_config *cfg, lfs_block_t block,
if (err) { if (err) {
err = -errno; err = -errno;
LFS_TRACE("lfs_emubd_prog -> %d", err); LFS_TRACE("lfs_emubd_prog -> %d", err);
fclose(f);
return err; return err;
} }
@@ -237,6 +242,7 @@ int lfs_emubd_prog(const struct lfs_config *cfg, lfs_block_t block,
if (res < size) { if (res < size) {
err = -errno; err = -errno;
LFS_TRACE("lfs_emubd_prog -> %d", err); LFS_TRACE("lfs_emubd_prog -> %d", err);
fclose(f);
return err; return err;
} }
@@ -244,6 +250,7 @@ int lfs_emubd_prog(const struct lfs_config *cfg, lfs_block_t block,
if (err) { if (err) {
err = -errno; err = -errno;
LFS_TRACE("lfs_emubd_prog -> %d", err); LFS_TRACE("lfs_emubd_prog -> %d", err);
fclose(f);
return err; return err;
} }
@@ -252,6 +259,7 @@ int lfs_emubd_prog(const struct lfs_config *cfg, lfs_block_t block,
if (res < 1) { if (res < 1) {
err = -errno; err = -errno;
LFS_TRACE("lfs_emubd_prog -> %d", err); LFS_TRACE("lfs_emubd_prog -> %d", err);
fclose(f);
return err; return err;
} }
@@ -340,6 +348,7 @@ int lfs_emubd_sync(const struct lfs_config *cfg) {
if (res < 1) { if (res < 1) {
int err = -errno; int err = -errno;
LFS_TRACE("lfs_emubd_sync -> %d", err); LFS_TRACE("lfs_emubd_sync -> %d", err);
fclose(f);
return err; return err;
} }
@@ -364,6 +373,7 @@ int lfs_emubd_sync(const struct lfs_config *cfg) {
if (res < 1) { if (res < 1) {
err = -errno; err = -errno;
LFS_TRACE("lfs_emubd_sync -> %d", err); LFS_TRACE("lfs_emubd_sync -> %d", err);
fclose(f);
return err; return err;
} }
@@ -388,6 +398,7 @@ int lfs_emubd_sync(const struct lfs_config *cfg) {
if (res < 1) { if (res < 1) {
err = -errno; err = -errno;
LFS_TRACE("lfs_emubd_sync -> %d", err); LFS_TRACE("lfs_emubd_sync -> %d", err);
fclose(f);
return err; return err;
} }