github-mirrors/thirdparty-littlefs
1
0
Fork 0
mirror of https://github.com/eledio-devices/thirdparty-littlefs.git synced 2025-11-01 00:38:29 +01:00
Code Issues Packages Projects Releases Wiki Activity

Restructured block devices again for better test exploitation

Browse Source 
Also finished migrating tests with test_relocations and test_exhaustion.

The issue I was running into when migrating these tests was a lack of
flexibility with what you could do with the block devices. It was
possible to hack in some hooks for things like bad blocks and power
loss, but it wasn't clean or easily extendable.

The solution here was to just put all of these test extensions into a
third block device, testbd, that uses the other two example block
devices internally.

testbd has several useful features for testing. Note this makes it a
pretty terrible block device _example_ since these hooks look more
complicated than a block device needs to be.

- testbd can simulate different erase values, supporting 1s, 0s, other byte
  patterns, or no erases at all (which can cause surprising bugs). This
  actually depends on the simulated erase values in ramdb and filebd.

  I did try to move this out of rambd/filebd, but it's not possible to
  simulate erases in testbd without buffering entire blocks and creating
  an excessive amount of extra write operations.

- testbd also helps simulate power-loss by containing a "power cycles"
  counter that is decremented every write operation until it calls exit.

  This is notably faster than the previous gdb approach, which is
  valuable since the reentrant tests tend to take a while to resolve.

- testbd also tracks wear, which can be manually set and read. This is
  very useful for testing things like bad block handling, wear leveling,
  or even changing the effective size of the block device at runtime.
This commit is contained in:
Christopher Haster
2020-01-16 06:30:40 -06:00
parent ecc2857c0e
commit fb65057a3c
16 changed files with 1067 additions and 238 deletions
Download Patch File Download Diff File Expand all files Collapse all files

114
tests_/test_badblocks.toml
View File

@@ -1,50 +1,12 @@
# special bad-block block device hook for simulating blocks
# that are no longer writable
code = '''
lfs_block_t *bbbd_badblocks;
size_t bbbd_badblocks_count;
int bbbd_read(const struct lfs_config *c, lfs_block_t block,
lfs_off_t off, void *buffer, lfs_size_t size) {
for (size_t i = 0; i < bbbd_badblocks_count; i++) {
if (bbbd_badblocks[i] == block) {
return LFS_ERR_CORRUPT;
}
}
return lfs_testbd_read(c, block, off, buffer, size);
}
int bbbd_prog(const struct lfs_config *c, lfs_block_t block,
lfs_off_t off, const void *buffer, lfs_size_t size) {
for (size_t i = 0; i < bbbd_badblocks_count; i++) {
if (bbbd_badblocks[i] == block) {
return LFS_ERR_CORRUPT;
}
}
return lfs_testbd_prog(c, block, off, buffer, size);
}
int bbbd_erase(const struct lfs_config *c, lfs_block_t block) {
for (size_t i = 0; i < bbbd_badblocks_count; i++) {
if (bbbd_badblocks[i] == block) {
return LFS_ERR_CORRUPT;
}
}
return lfs_testbd_erase(c, block);
}
'''
[[case]] # single bad blocks
define.LFS_BD_PROG = 'bbbd_prog'
define.LFS_ERASE_CYCLES = 0xffffffff
define.LFS_BADBLOCK_BEHAVIOR = 'LFS_TESTBD_BADBLOCK_NOPROG'
define.NAMEMULT = 64
define.FILEMULT = 1
code = '''
for (lfs_block_t badblock = 2; badblock < LFS_BLOCK_COUNT; badblock++) {
bbbd_badblocks = &(lfs_block_t){badblock};
bbbd_badblocks_count = 1;
lfs_testbd_setwear(&cfg, badblock-1, 0) => 0;
lfs_testbd_setwear(&cfg, badblock, 0xffffffff) => 0;
lfs_format(&lfs, &cfg) => 0;
@@ -103,13 +65,14 @@ code = '''
'''
[[case]] # single persistent blocks (can't erase)
define.LFS_BD_ERASE = 'bbbd_erase'
define.LFS_ERASE_CYCLES = 0xffffffff
define.LFS_BADBLOCK_BEHAVIOR = 'LFS_TESTBD_BADBLOCK_NOERASE'
define.NAMEMULT = 64
define.FILEMULT = 1
code = '''
for (lfs_block_t badblock = 2; badblock < LFS_BLOCK_COUNT; badblock++) {
bbbd_badblocks = &(lfs_block_t){badblock};
bbbd_badblocks_count = 1;
lfs_testbd_setwear(&cfg, badblock-1, 0) => 0;
lfs_testbd_setwear(&cfg, badblock, 0xffffffff) => 0;
lfs_format(&lfs, &cfg) => 0;
@@ -168,13 +131,14 @@ code = '''
'''
[[case]] # single unreadable blocks (can't read)
define.LFS_BD_READ = 'bbbd_read'
define.LFS_ERASE_CYCLES = 0xffffffff
define.LFS_BADBLOCK_BEHAVIOR = 'LFS_TESTBD_BADBLOCK_NOREAD'
define.NAMEMULT = 64
define.FILEMULT = 1
code = '''
for (lfs_block_t badblock = 2; badblock < LFS_BLOCK_COUNT; badblock++) {
bbbd_badblocks = &(lfs_block_t){badblock};
bbbd_badblocks_count = 1;
for (lfs_block_t badblock = 2; badblock < LFS_BLOCK_COUNT/2; badblock++) {
lfs_testbd_setwear(&cfg, badblock-1, 0) => 0;
lfs_testbd_setwear(&cfg, badblock, 0xffffffff) => 0;
lfs_format(&lfs, &cfg) => 0;
@@ -233,17 +197,17 @@ code = '''
'''
[[case]] # region corruption (causes cascading failures)
define.LFS_BD_PROG = '"BADTYPE == 0 ? bbbd_prog : lfs_testbd_prog "'
define.LFS_BD_ERASE = '"BADTYPE == 1 ? bbbd_erase : lfs_testbd_erase"'
define.LFS_BD_READ = '"BADTYPE == 2 ? bbbd_read : lfs_testbd_read "'
define.BADTYPE = 'range(3)'
define.LFS_ERASE_CYCLES = 0xffffffff
define.LFS_BADBLOCK_BEHAVIOR = [
'LFS_TESTBD_BADBLOCK_NOPROG',
'LFS_TESTBD_BADBLOCK_NOERASE',
'LFS_TESTBD_BADBLOCK_NOREAD',
]
define.NAMEMULT = 64
define.FILEMULT = 1
code = '''
bbbd_badblocks_count = LFS_BLOCK_COUNT/2;
bbbd_badblocks = malloc(bbbd_badblocks_count*sizeof(lfs_block_t));
for (size_t i = 0; i < bbbd_badblocks_count; i++) {
bbbd_badblocks[i] = i+2;
for (lfs_block_t i = 0; i < (LFS_BLOCK_COUNT-2)/2; i++) {
lfs_testbd_setwear(&cfg, i+2, 0xffffffff) => 0;
}
lfs_format(&lfs, &cfg) => 0;
@@ -299,22 +263,20 @@ code = '''
lfs_file_close(&lfs, &file) => 0;
}
lfs_unmount(&lfs) => 0;
free(bbbd_badblocks);
'''
[[case]] # alternating corruption (causes cascading failures)
define.LFS_BD_PROG = '"BADTYPE == 0 ? bbbd_prog : lfs_testbd_prog "'
define.LFS_BD_ERASE = '"BADTYPE == 1 ? bbbd_erase : lfs_testbd_erase"'
define.LFS_BD_READ = '"BADTYPE == 2 ? bbbd_read : lfs_testbd_read "'
define.BADTYPE = 'range(3)'
define.LFS_ERASE_CYCLES = 0xffffffff
define.LFS_BADBLOCK_BEHAVIOR = [
'LFS_TESTBD_BADBLOCK_NOPROG',
'LFS_TESTBD_BADBLOCK_NOERASE',
'LFS_TESTBD_BADBLOCK_NOREAD',
]
define.NAMEMULT = 64
define.FILEMULT = 1
code = '''
bbbd_badblocks_count = LFS_BLOCK_COUNT/2;
bbbd_badblocks = malloc(bbbd_badblocks_count*sizeof(lfs_block_t));
for (size_t i = 0; i < bbbd_badblocks_count; i++) {
bbbd_badblocks[i] = (2*i) + 2;
for (lfs_block_t i = 0; i < (LFS_BLOCK_COUNT-2)/2; i++) {
lfs_testbd_setwear(&cfg, (2*i) + 2, 0xffffffff) => 0;
}
lfs_format(&lfs, &cfg) => 0;
@@ -370,6 +332,20 @@ code = '''
lfs_file_close(&lfs, &file) => 0;
}
lfs_unmount(&lfs) => 0;
free(bbbd_badblocks);
'''
# other corner cases
[[case]] # bad superblocks (corrupt 1 or 0)
define.LFS_ERASE_CYCLES = 0xffffffff
define.LFS_BADBLOCK_BEHAVIOR = [
'LFS_TESTBD_BADBLOCK_NOPROG',
'LFS_TESTBD_BADBLOCK_NOERASE',
'LFS_TESTBD_BADBLOCK_NOREAD',
]
code = '''
lfs_testbd_setwear(&cfg, 0, 0xffffffff) => 0;
lfs_testbd_setwear(&cfg, 1, 0xffffffff) => 0;
lfs_format(&lfs, &cfg) => LFS_ERR_NOSPC;
lfs_mount(&lfs, &cfg) => LFS_ERR_CORRUPT;
'''