xPablo.cz/ESPAsyncTCP
2
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Aktualizace na verzi 1.2.3

Browse Source
This commit is contained in:
Pavel Brychta 2021-01-11 10:11:38 +01:00
parent 0682e7222b
commit b396b00596
7 changed files with 108 additions and 60 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
library.json
View File

@ -12,7 +12,7 @@
"type": "git", "type": "git",
"url": "https://git.xpablo.cz/xPablo.cz/ESPAsyncTCP.git" "url": "https://git.xpablo.cz/xPablo.cz/ESPAsyncTCP.git"
}, },
"version": "1.2.2", "version": "1.2.3",
"license": "LGPL-3.0", "license": "LGPL-3.0",
"frameworks": "arduino", "frameworks": "arduino",
"platforms": "espressif8266", "platforms": "espressif8266",

2
library.properties
View File

@ -1,5 +1,5 @@
name=ESPAsyncTCP name=ESPAsyncTCP
version=1.2.2 version=1.2.3
author=Me-No-Dev author=Me-No-Dev
maintainer=xPablo maintainer=xPablo
sentence=Async TCP Library for ESP8266 and ESP31B sentence=Async TCP Library for ESP8266 and ESP31B

50
src/DebugPrintMacros.h
View File

@ -27,18 +27,34 @@ inline struct _DEBUG_TIME_STAMP debugTimeStamp(void) {
} }
#endif #endif
#if defined(DEBUG_ESP_PORT) && !defined(DEBUG_ESP_PORT_PRINTF)
#ifdef __cplusplus
#define DEBUG_ESP_PORT_PRINTF(format, ...) DEBUG_ESP_PORT.printf((format), ##__VA_ARGS__)
#define DEBUG_ESP_PORT_PRINTF_F(format, ...) DEBUG_ESP_PORT.printf_P(PSTR(format), ##__VA_ARGS__)
#define DEBUG_ESP_PORT_FLUSH DEBUG_ESP_PORT.flush
#else
// Handle debug printing from .c without CPP Stream, Print, ... classes
// Cannot handle flash strings in this setting
#define DEBUG_ESP_PORT_PRINTF ets_uart_printf
#define DEBUG_ESP_PORT_PRINTF_F ets_uart_printf
#define DEBUG_ESP_PORT_FLUSH (void)0
#endif
#endif
#if defined(DEBUG_ESP_PORT) && !defined(DEBUG_GENERIC) #if defined(DEBUG_ESP_PORT) && !defined(DEBUG_GENERIC)
#define DEBUG_GENERIC( module, format, ... ) \ #define DEBUG_GENERIC( module, format, ... ) \
do { \ do { \
struct _DEBUG_TIME_STAMP st = debugTimeStamp(); \ struct _DEBUG_TIME_STAMP st = debugTimeStamp(); \
DEBUG_ESP_PORT.printf( DEBUG_TIME_STAMP_FMT module " " format, st.whole, st.dec, ##__VA_ARGS__ ); \ DEBUG_ESP_PORT_PRINTF( (DEBUG_TIME_STAMP_FMT module " " format), st.whole, st.dec, ##__VA_ARGS__ ); \
} while(false) } while(false)
#endif #endif
#if defined(DEBUG_ESP_PORT) && !defined(DEBUG_GENERIC_P) #if defined(DEBUG_ESP_PORT) && !defined(DEBUG_GENERIC_F)
#define DEBUG_GENERIC_P( module, format, ... ) \ #define DEBUG_GENERIC_F( module, format, ... ) \
do { \ do { \
struct _DEBUG_TIME_STAMP st = debugTimeStamp(); \ struct _DEBUG_TIME_STAMP st = debugTimeStamp(); \
DEBUG_ESP_PORT.printf_P(PSTR( DEBUG_TIME_STAMP_FMT module " " format ), st.whole, st.dec, ##__VA_ARGS__ ); \ DEBUG_ESP_PORT_PRINTF_F( (DEBUG_TIME_STAMP_FMT module " " format), st.whole, st.dec, ##__VA_ARGS__ ); \
} while(false) } while(false)
#endif #endif
@ -47,16 +63,16 @@ inline struct _DEBUG_TIME_STAMP debugTimeStamp(void) {
do { \ do { \
if ( !(a) ) { \ if ( !(a) ) { \
DEBUG_GENERIC( module, "%s:%s:%u: ASSERT("#a") failed!\n", __FILE__, __func__, __LINE__); \ DEBUG_GENERIC( module, "%s:%s:%u: ASSERT("#a") failed!\n", __FILE__, __func__, __LINE__); \
DEBUG_ESP_PORT.flush(); \ DEBUG_ESP_PORT_FLUSH(); \
} \ } \
} while(false) } while(false)
#endif #endif
#if defined(DEBUG_GENERIC_P) && !defined(ASSERT_GENERIC_P) #if defined(DEBUG_GENERIC_F) && !defined(ASSERT_GENERIC_F)
#define ASSERT_GENERIC_P( a, module ) \ #define ASSERT_GENERIC_F( a, module ) \
do { \ do { \
if ( !(a) ) { \ if ( !(a) ) { \
DEBUG_GENERIC_P( module, "%s:%s:%u: ASSERT("#a") failed!\n", __FILE__, __func__, __LINE__); \ DEBUG_GENERIC_F( module, "%s:%s:%u: ASSERT("#a") failed!\n", __FILE__, __func__, __LINE__); \
DEBUG_ESP_PORT.flush(); \ DEBUG_ESP_PORT_FLUSH(); \
} \ } \
} while(false) } while(false)
#endif #endif
@ -65,32 +81,32 @@ inline struct _DEBUG_TIME_STAMP debugTimeStamp(void) {
#define DEBUG_GENERIC(...) do { (void)0;} while(false) #define DEBUG_GENERIC(...) do { (void)0;} while(false)
#endif #endif
#ifndef DEBUG_GENERIC_P #ifndef DEBUG_GENERIC_F
#define DEBUG_GENERIC_P(...) do { (void)0;} while(false) #define DEBUG_GENERIC_F(...) do { (void)0;} while(false)
#endif #endif
#ifndef ASSERT_GENERIC #ifndef ASSERT_GENERIC
#define ASSERT_GENERIC(...) do { (void)0;} while(false) #define ASSERT_GENERIC(...) do { (void)0;} while(false)
#endif #endif
#ifndef ASSERT_GENERIC_P #ifndef ASSERT_GENERIC_F
#define ASSERT_GENERIC_P(...) do { (void)0;} while(false) #define ASSERT_GENERIC_F(...) do { (void)0;} while(false)
#endif #endif
#ifndef DEBUG_ESP_PRINTF #ifndef DEBUG_ESP_PRINTF
#define DEBUG_ESP_PRINTF( format, ...) DEBUG_GENERIC_P("[%s]", format, &_FILENAME_[1], ##__VA_ARGS__) #define DEBUG_ESP_PRINTF( format, ...) DEBUG_GENERIC_F("[%s]", format, &_FILENAME_[1], ##__VA_ARGS__)
#endif #endif
#if defined(DEBUG_ESP_ASYNC_TCP) && !defined(ASYNC_TCP_DEBUG) #if defined(DEBUG_ESP_ASYNC_TCP) && !defined(ASYNC_TCP_DEBUG)
#define ASYNC_TCP_DEBUG( format, ...) DEBUG_GENERIC_P("[ASYNC_TCP]", format, ##__VA_ARGS__) #define ASYNC_TCP_DEBUG( format, ...) DEBUG_GENERIC_F("[ASYNC_TCP]", format, ##__VA_ARGS__)
#endif #endif
#ifndef ASYNC_TCP_ASSERT #ifndef ASYNC_TCP_ASSERT
#define ASYNC_TCP_ASSERT( a ) ASSERT_GENERIC_P( (a), "[ASYNC_TCP]") #define ASYNC_TCP_ASSERT( a ) ASSERT_GENERIC_F( (a), "[ASYNC_TCP]")
#endif #endif
#if defined(DEBUG_ESP_TCP_SSL) && !defined(TCP_SSL_DEBUG) #if defined(DEBUG_ESP_TCP_SSL) && !defined(TCP_SSL_DEBUG)
#define TCP_SSL_DEBUG( format, ...) DEBUG_GENERIC_P("[TCP_SSL]", format, ##__VA_ARGS__) #define TCP_SSL_DEBUG( format, ...) DEBUG_GENERIC_F("[TCP_SSL]", format, ##__VA_ARGS__)
#endif #endif
#endif //_DEBUG_PRINT_MACROS_H #endif //_DEBUG_PRINT_MACROS_H

62
src/ESPAsyncTCP.cpp
View File

@ -70,6 +70,7 @@ yield(), etc.
*/ */
#include "Arduino.h" #include "Arduino.h"
#include "ESPAsyncTCP.h" #include "ESPAsyncTCP.h"
@ -179,7 +180,6 @@ AsyncClient::AsyncClient(tcp_pcb* pcb):
, _ack_pcb(true) , _ack_pcb(true)
, _tx_unacked_len(0) , _tx_unacked_len(0)
, _tx_acked_len(0) , _tx_acked_len(0)
, _tx_unsent_len(0)
, _rx_ack_len(0) , _rx_ack_len(0)
, _rx_last_packet(0) , _rx_last_packet(0)
, _rx_since_timeout(0) , _rx_since_timeout(0)
@ -355,10 +355,12 @@ void AsyncClient::abort(){
void AsyncClient::close(bool now){ void AsyncClient::close(bool now){
if(_pcb) if(_pcb)
tcp_recved(_pcb, _rx_ack_len); tcp_recved(_pcb, _rx_ack_len);
if(now) if(now) {
ASYNC_TCP_DEBUG("close[%u]: AsyncClient 0x%" PRIXPTR "\n", getConnectionId(), uintptr_t(this));
_close(); _close();
else } else {
_close_pcb = true; _close_pcb = true;
}
} }
void AsyncClient::stop() { void AsyncClient::stop() {
@ -410,7 +412,7 @@ size_t AsyncClient::add(const char* data, size_t size, uint8_t apiflags) {
ASYNC_TCP_DEBUG("_add[%u]: tcp_write() returned err: %s(%ld)\n", getConnectionId(), errorToString(err), err); ASYNC_TCP_DEBUG("_add[%u]: tcp_write() returned err: %s(%ld)\n", getConnectionId(), errorToString(err), err);
return 0; return 0;
} }
_tx_unsent_len += will_send; _tx_unacked_len += will_send;
return will_send; return will_send;
} }
@ -423,13 +425,10 @@ bool AsyncClient::send(){
if(err == ERR_OK){ if(err == ERR_OK){
_pcb_busy = true; _pcb_busy = true;
_pcb_sent_at = millis(); _pcb_sent_at = millis();
_tx_unacked_len += _tx_unsent_len;
_tx_unsent_len = 0;
return true; return true;
} }
ASYNC_TCP_DEBUG("send[%u]: tcp_output() returned err: %s(%ld)", getConnectionId(), errorToString(err), err); ASYNC_TCP_DEBUG("send[%u]: tcp_output() returned err: %s(%ld)", getConnectionId(), errorToString(err), err);
_tx_unsent_len = 0;
return false; return false;
} }
@ -503,6 +502,7 @@ void AsyncClient::_close(){
err_t err = tcp_close(_pcb); err_t err = tcp_close(_pcb);
if(ERR_OK == err) { if(ERR_OK == err) {
setCloseError(err); setCloseError(err);
ASYNC_TCP_DEBUG("_close[%u]: AsyncClient 0x%" PRIXPTR "\n", getConnectionId(), uintptr_t(this));
} else { } else {
ASYNC_TCP_DEBUG("_close[%u]: abort() called for AsyncClient 0x%" PRIXPTR "\n", getConnectionId(), uintptr_t(this)); ASYNC_TCP_DEBUG("_close[%u]: abort() called for AsyncClient 0x%" PRIXPTR "\n", getConnectionId(), uintptr_t(this));
abort(); abort();
@ -546,21 +546,6 @@ void AsyncClient::_sent(std::shared_ptr<ACErrorTracker>& errorTracker, tcp_pcb*
return; return;
#endif #endif
_rx_last_packet = millis(); _rx_last_packet = millis();
// If add() is called, then send(), we have unacked len with data, and _pcb_busy true
// we have space so we call add with some more data, we call then canSend()
// That returns false, because _pcb_busy is true, so we dont call send().
// Then this function gets called, but not only with the bytes queued before the send() call
// also the data added with add() is send, and acked, now we have more acked data than expected
// if we don't check for this unackled overflows when substracting acked length and
// pcb_busy never goes false, if we keep checking canSend(), we never call send even if we did
// _pcb_busy will remain true.
if (len > _tx_unacked_len)
{
_tx_unacked_len += _tx_unsent_len;
_tx_unsent_len = 0;
}
_tx_unacked_len -= len; _tx_unacked_len -= len;
_tx_acked_len += len; _tx_acked_len += len;
ASYNC_TCP_DEBUG("_sent[%u]: %4u, unacked=%4u, acked=%4u, space=%4u\n", errorTracker->getConnectionId(), len, _tx_unacked_len, _tx_acked_len, space()); ASYNC_TCP_DEBUG("_sent[%u]: %4u, unacked=%4u, acked=%4u, space=%4u\n", errorTracker->getConnectionId(), len, _tx_unacked_len, _tx_acked_len, space());
@ -679,6 +664,7 @@ void AsyncClient::_poll(std::shared_ptr<ACErrorTracker>& errorTracker, tcp_pcb*
// Close requested // Close requested
if(_close_pcb){ if(_close_pcb){
ASYNC_TCP_DEBUG("_poll[%u]: Process _close_pcb.\n", errorTracker->getConnectionId() );
_close_pcb = false; _close_pcb = false;
_close(); _close();
return; return;
@ -694,12 +680,14 @@ void AsyncClient::_poll(std::shared_ptr<ACErrorTracker>& errorTracker, tcp_pcb*
} }
// RX Timeout // RX Timeout
if(_rx_since_timeout && (now - _rx_last_packet) >= (_rx_since_timeout * 1000)){ if(_rx_since_timeout && (now - _rx_last_packet) >= (_rx_since_timeout * 1000)){
ASYNC_TCP_DEBUG("_poll[%u]: RX Timeout.\n", errorTracker->getConnectionId() );
_close(); _close();
return; return;
} }
#if ASYNC_TCP_SSL_ENABLED #if ASYNC_TCP_SSL_ENABLED
// SSL Handshake Timeout // SSL Handshake Timeout
if(_pcb_secure && !_handshake_done && (now - _rx_last_packet) >= 2000){ if(_pcb_secure && !_handshake_done && (now - _rx_last_packet) >= 2000){
ASYNC_TCP_DEBUG("_poll[%u]: SSL Handshake Timeout.\n", errorTracker->getConnectionId() );
_close(); _close();
return; return;
} }
@ -777,12 +765,15 @@ err_t AsyncClient::_s_connected(void* arg, void* tpcb, err_t err){
#if ASYNC_TCP_SSL_ENABLED #if ASYNC_TCP_SSL_ENABLED
void AsyncClient::_s_data(void *arg, struct tcp_pcb *tcp, uint8_t * data, size_t len){ void AsyncClient::_s_data(void *arg, struct tcp_pcb *tcp, uint8_t * data, size_t len){
(void)tcp;
AsyncClient *c = reinterpret_cast<AsyncClient*>(arg); AsyncClient *c = reinterpret_cast<AsyncClient*>(arg);
if(c->_recv_cb) if(c->_recv_cb)
c->_recv_cb(c->_recv_cb_arg, c, data, len); c->_recv_cb(c->_recv_cb_arg, c, data, len);
} }
void AsyncClient::_s_handshake(void *arg, struct tcp_pcb *tcp, SSL *ssl){ void AsyncClient::_s_handshake(void *arg, struct tcp_pcb *tcp, SSL *ssl){
(void)tcp;
(void)ssl;
AsyncClient *c = reinterpret_cast<AsyncClient*>(arg); AsyncClient *c = reinterpret_cast<AsyncClient*>(arg);
c->_handshake_done = true; c->_handshake_done = true;
if(c->_connect_cb) if(c->_connect_cb)
@ -790,6 +781,12 @@ void AsyncClient::_s_handshake(void *arg, struct tcp_pcb *tcp, SSL *ssl){
} }
void AsyncClient::_s_ssl_error(void *arg, struct tcp_pcb *tcp, int8_t err){ void AsyncClient::_s_ssl_error(void *arg, struct tcp_pcb *tcp, int8_t err){
(void)tcp;
#ifdef DEBUG_ESP_ASYNC_TCP
AsyncClient *c = reinterpret_cast<AsyncClient*>(arg);
auto errorTracker = c->getACErrorTracker();
ASYNC_TCP_DEBUG("_ssl_error[%u] err = %d\n", errorTracker->getConnectionId(), err);
#endif
reinterpret_cast<AsyncClient*>(arg)->_ssl_error(err); reinterpret_cast<AsyncClient*>(arg)->_ssl_error(err);
} }
#endif #endif
@ -1245,7 +1242,7 @@ err_t AsyncServer::_accept(tcp_pcb* pcb, err_t err){
} }
return ERR_OK; return ERR_OK;
} }
ASYNC_TCP_DEBUG("### put to wait: %d\n", _clients_waiting); //1 ASYNC_TCP_DEBUG("### put to wait: %d\n", _clients_waiting);
new_item->pcb = pcb; new_item->pcb = pcb;
new_item->pb = NULL; new_item->pb = NULL;
new_item->next = NULL; new_item->next = NULL;
@ -1267,6 +1264,7 @@ err_t AsyncServer::_accept(tcp_pcb* pcb, err_t err){
if(c){ if(c){
ASYNC_TCP_DEBUG("_accept[%u]: SSL connected\n", c->getConnectionId()); ASYNC_TCP_DEBUG("_accept[%u]: SSL connected\n", c->getConnectionId());
c->onConnect([this](void * arg, AsyncClient *c){ c->onConnect([this](void * arg, AsyncClient *c){
(void)arg;
_connect_cb(_connect_cb_arg, c); _connect_cb(_connect_cb_arg, c);
}, this); }, this);
} else { } else {
@ -1318,6 +1316,7 @@ err_t AsyncServer::_s_accept(void *arg, tcp_pcb* pcb, err_t err){
#if ASYNC_TCP_SSL_ENABLED #if ASYNC_TCP_SSL_ENABLED
err_t AsyncServer::_poll(tcp_pcb* pcb){ err_t AsyncServer::_poll(tcp_pcb* pcb){
err_t err = ERR_OK;
if(!tcp_ssl_has_client() && _pending){ if(!tcp_ssl_has_client() && _pending){
struct pending_pcb * p = _pending; struct pending_pcb * p = _pending;
if(p->pcb == pcb){ if(p->pcb == pcb){
@ -1329,29 +1328,34 @@ err_t AsyncServer::_poll(tcp_pcb* pcb){
p->next = b->next; p->next = b->next;
p = b; p = b;
} }
ASYNC_TCP_DEBUG("### remove from wait: %d\n", _clients_waiting); //1 ASYNC_TCP_DEBUG("### remove from wait: %d\n", _clients_waiting);
AsyncClient *c = new (std::nothrow) AsyncClient(pcb, _ssl_ctx); AsyncClient *c = new (std::nothrow) AsyncClient(pcb, _ssl_ctx);
if(c){ if(c){
c->onConnect([this](void * arg, AsyncClient *c){ c->onConnect([this](void * arg, AsyncClient *c){
(void)arg;
_connect_cb(_connect_cb_arg, c); _connect_cb(_connect_cb_arg, c);
}, this); }, this);
if(p->pb) if(p->pb) {
c->_recv(pcb, p->pb, 0); auto errorTracker = c->getACErrorTracker();
c->_recv(errorTracker, pcb, p->pb, 0);
err = errorTracker->getCallbackCloseError();
}
} }
// Should there be error handling for when "new AsynClient" fails?? // Should there be error handling for when "new AsynClient" fails??
free(p); free(p);
} }
return ERR_OK; return err;
} }
err_t AsyncServer::_recv(struct tcp_pcb *pcb, struct pbuf *pb, err_t err){ err_t AsyncServer::_recv(struct tcp_pcb *pcb, struct pbuf *pb, err_t err){
(void)err;
if(!_pending) if(!_pending)
return ERR_OK; return ERR_OK;
struct pending_pcb * p; struct pending_pcb * p;
if(!pb){ if(!pb){
ASYNC_TCP_DEBUG("### close from wait: %d\n", _clients_waiting); //1 ASYNC_TCP_DEBUG("### close from wait: %d\n", _clients_waiting);
p = _pending; p = _pending;
if(p->pcb == pcb){ if(p->pcb == pcb){
_pending = _pending->next; _pending = _pending->next;
@ -1372,7 +1376,7 @@ err_t AsyncServer::_recv(struct tcp_pcb *pcb, struct pbuf *pb, err_t err){
return ERR_ABRT; return ERR_ABRT;
} }
} else { } else {
ASYNC_TCP_DEBUG("### wait _recv: %u %d\n", pb->tot_len, _clients_waiting); //1 ASYNC_TCP_DEBUG("### wait _recv: %u %d\n", pb->tot_len, _clients_waiting);
p = _pending; p = _pending;
while(p && p->pcb != pcb) while(p && p->pcb != pcb)
p = p->next; p = p->next;

1
src/ESPAsyncTCP.h
View File

@ -136,7 +136,6 @@ class AsyncClient {
bool _ack_pcb; bool _ack_pcb;
uint32_t _tx_unacked_len; uint32_t _tx_unacked_len;
uint32_t _tx_acked_len; uint32_t _tx_acked_len;
uint32_t _tx_unsent_len;
uint32_t _rx_ack_len; uint32_t _rx_ack_len;
uint32_t _rx_last_packet; uint32_t _rx_last_packet;
uint32_t _rx_since_timeout; uint32_t _rx_since_timeout;

6
src/async_config.h
View File

@ -20,9 +20,11 @@
// Starting with Arduino Core 2.4.0 and up the define of DEBUG_ESP_PORT // Starting with Arduino Core 2.4.0 and up the define of DEBUG_ESP_PORT
// can be handled through the Arduino IDE Board options instead of here. // can be handled through the Arduino IDE Board options instead of here.
// #define DEBUG_ESP_PORT Serial // #define DEBUG_ESP_PORT Serial
// #define DEBUG_ESP_ASYNC_TCP 1 // #define DEBUG_ESP_ASYNC_TCP 1
// #define DEBUG_ESP_TCP_SSL 1 // #define DEBUG_ESP_TCP_SSL 1
#ifndef DEBUG_SKIP__DEBUG_PRINT_MACROS
#include <DebugPrintMacros.h> #include <DebugPrintMacros.h>
#ifndef ASYNC_TCP_ASSERT #ifndef ASYNC_TCP_ASSERT
@ -35,4 +37,6 @@
#define TCP_SSL_DEBUG(...) do { (void)0;} while(false) #define TCP_SSL_DEBUG(...) do { (void)0;} while(false)
#endif #endif
#endif
#endif /* LIBRARIES_ESPASYNCTCP_SRC_ASYNC_CONFIG_H_ */ #endif /* LIBRARIES_ESPASYNCTCP_SRC_ASYNC_CONFIG_H_ */

45
src/tcp_axtls.c
View File

@ -22,7 +22,13 @@
* Compatibility for AxTLS with LWIP raw tcp mode (http://lwip.wikia.com/wiki/Raw/TCP) * Compatibility for AxTLS with LWIP raw tcp mode (http://lwip.wikia.com/wiki/Raw/TCP)
* Original Code and Inspiration: Slavey Karadzhov * Original Code and Inspiration: Slavey Karadzhov
*/ */
// To handle all the definitions needed for debug printing, we need to delay
// macro definitions till later.
#define DEBUG_SKIP__DEBUG_PRINT_MACROS 1
#include <async_config.h> #include <async_config.h>
#undef DEBUG_SKIP__DEBUG_PRINT_MACROS
#if ASYNC_TCP_SSL_ENABLED #if ASYNC_TCP_SSL_ENABLED
#include "lwip/opt.h" #include "lwip/opt.h"
@ -34,6 +40,13 @@
#include <stdbool.h> #include <stdbool.h>
#include <tcp_axtls.h> #include <tcp_axtls.h>
// ets_uart_printf is defined in esp8266_undocumented.h, in newer Arduino ESP8266 Core.
extern int ets_uart_printf(const char *format, ...) __attribute__ ((format (printf, 1, 2)));
#include <DebugPrintMacros.h>
#ifndef TCP_SSL_DEBUG
#define TCP_SSL_DEBUG(...) do { (void)0;} while(false)
#endif
uint8_t * default_private_key = NULL; uint8_t * default_private_key = NULL;
uint16_t default_private_key_len = 0; uint16_t default_private_key_len = 0;
@ -377,7 +390,8 @@ int tcp_ssl_read(struct tcp_pcb *tcp, struct pbuf *p) {
do { do {
read_bytes = ssl_read(fd_data->ssl, &read_buf); read_bytes = ssl_read(fd_data->ssl, &read_buf);
//TCP_SSL_DEBUG("tcp_ssl_ssl_read: %d\n", read_bytes); TCP_SSL_DEBUG("tcp_ssl_ssl_read: %d\n", read_bytes);
if(read_bytes < SSL_OK) { if(read_bytes < SSL_OK) {
if(read_bytes != SSL_CLOSE_NOTIFY) { if(read_bytes != SSL_CLOSE_NOTIFY) {
TCP_SSL_DEBUG("tcp_ssl_read: read error: %d\n", read_bytes); TCP_SSL_DEBUG("tcp_ssl_read: read error: %d\n", read_bytes);
@ -387,20 +401,31 @@ int tcp_ssl_read(struct tcp_pcb *tcp, struct pbuf *p) {
} else if(read_bytes > 0){ } else if(read_bytes > 0){
if(fd_data->on_data){ if(fd_data->on_data){
fd_data->on_data(fd_data->arg, tcp, read_buf, read_bytes); fd_data->on_data(fd_data->arg, tcp, read_buf, read_bytes);
// fd_data may have been freed in callback
fd_data = tcp_ssl_get(tcp);
if(NULL == fd_data)
return SSL_CLOSE_NOTIFY;
} }
total_bytes+= read_bytes; total_bytes+= read_bytes;
} else { } else {
if(fd_data->handshake != SSL_OK) { if(fd_data->handshake != SSL_OK) {
fd_data->handshake = ssl_handshake_status(fd_data->ssl); // fd_data may be freed in callbacks.
if(fd_data->handshake == SSL_OK){ int handshake = fd_data->handshake = ssl_handshake_status(fd_data->ssl);
//TCP_SSL_DEBUG("tcp_ssl_read: handshake OK\n"); if(handshake == SSL_OK){
TCP_SSL_DEBUG("tcp_ssl_read: handshake OK\n");
if(fd_data->on_handshake) if(fd_data->on_handshake)
fd_data->on_handshake(fd_data->arg, fd_data->tcp, fd_data->ssl); fd_data->on_handshake(fd_data->arg, fd_data->tcp, fd_data->ssl);
} else if(fd_data->handshake != SSL_NOT_OK){ fd_data = tcp_ssl_get(tcp);
TCP_SSL_DEBUG("tcp_ssl_read: handshake error: %d\n", fd_data->handshake); if(NULL == fd_data)
return SSL_CLOSE_NOTIFY;
} else if(handshake != SSL_NOT_OK){
TCP_SSL_DEBUG("tcp_ssl_read: handshake error: %d\n", handshake);
if(fd_data->on_error) if(fd_data->on_error)
fd_data->on_error(fd_data->arg, fd_data->tcp, fd_data->handshake); fd_data->on_error(fd_data->arg, fd_data->tcp, handshake);
return fd_data->handshake; return handshake;
// With current code APP gets called twice at onError handler.
// Once here and again after return when handshake != SSL_CLOSE_NOTIFY.
// As always APP must never free resources at onError only at onDisconnect.
} }
} }
} }
@ -525,13 +550,13 @@ int ax_port_write(int fd, uint8_t *data, uint16_t len) {
TCP_SSL_DEBUG("ax_port_write: No memory %d (%d)\n", tcp_len, len); TCP_SSL_DEBUG("ax_port_write: No memory %d (%d)\n", tcp_len, len);
return err; return err;
} }
TCP_SSL_DEBUG("ax_port_write: tcp_write error: %d\n", err); TCP_SSL_DEBUG("ax_port_write: tcp_write error: %ld\n", err);
return err; return err;
} else if (err == ERR_OK) { } else if (err == ERR_OK) {
//TCP_SSL_DEBUG("ax_port_write: tcp_output: %d / %d\n", tcp_len, len); //TCP_SSL_DEBUG("ax_port_write: tcp_output: %d / %d\n", tcp_len, len);
err = tcp_output(fd_data->tcp); err = tcp_output(fd_data->tcp);
if(err != ERR_OK) { if(err != ERR_OK) {
TCP_SSL_DEBUG("ax_port_write: tcp_output err: %d\n", err); TCP_SSL_DEBUG("ax_port_write: tcp_output err: %ld\n", err);
return err; return err;
} }
} }