mirror of
				https://github.com/eledio-devices/thirdparty-ArduinoJson.git
				synced 2025-10-31 16:14:11 +01:00 
			
		
		
		
	as<char*>() now returns true when input is null (issue #330)
				
					
				
			This commit is contained in:
		| @@ -1,6 +1,11 @@ | ||||
| ArduinoJson: change log | ||||
| ======================= | ||||
|  | ||||
| HEAD | ||||
| ---- | ||||
|  | ||||
| * `as<char*>()` now returns `true` when input is `null` (issue #330) | ||||
|  | ||||
| v5.6.4 | ||||
| ------ | ||||
|  | ||||
|   | ||||
| @@ -300,8 +300,13 @@ class JsonVariant : public JsonVariantBase<JsonVariant> { | ||||
|     return T(); | ||||
|   } | ||||
|  | ||||
|   // DEPRECATED: use as<char*>() instead | ||||
|   const char *asString() const; | ||||
|  | ||||
|   // DEPRECATED: use as<JsonArray>() instead | ||||
|   JsonArray &asArray() const; | ||||
|  | ||||
|   // DEPRECATED: use as<JsonObject>() instead | ||||
|   JsonObject &asObject() const; | ||||
|  | ||||
|  private: | ||||
| @@ -324,7 +329,9 @@ class JsonVariant : public JsonVariantBase<JsonVariant> { | ||||
|     return _type == Internals::JSON_OBJECT; | ||||
|   } | ||||
|   bool isString() const { | ||||
|     return _type == Internals::JSON_STRING; | ||||
|     return _type == Internals::JSON_STRING || | ||||
|            _type == Internals::JSON_UNPARSED && _content.asString && | ||||
|                !strcmp("null", _content.asString); | ||||
|   } | ||||
|  | ||||
|   // The current type of the variant | ||||
|   | ||||
| @@ -5,8 +5,8 @@ | ||||
| // https://github.com/bblanchon/ArduinoJson | ||||
| // If you like this project, please add a star! | ||||
|  | ||||
| #include <gtest/gtest.h> | ||||
| #include <ArduinoJson.h> | ||||
| #include <gtest/gtest.h> | ||||
|  | ||||
| #define SUITE JsonVariant_Is_Tests | ||||
|  | ||||
| @@ -34,75 +34,222 @@ void assertIs(JsonArray& value) { | ||||
|   ASSERT_TRUE(variant.is<TTo>()); | ||||
| } | ||||
|  | ||||
| TEST(SUITE, ArrayIsArry) { assertIs<JsonArray&>(JsonArray::invalid()); } | ||||
| TEST(SUITE, ArrayIsBool) { assertIsNot<bool>(JsonArray::invalid()); } | ||||
| TEST(SUITE, ArrayIsDouble) { assertIsNot<double>(JsonArray::invalid()); } | ||||
| TEST(SUITE, ArrayIsFloat) { assertIsNot<float>(JsonArray::invalid()); } | ||||
| TEST(SUITE, ArrayIsInt) { assertIsNot<int>(JsonArray::invalid()); } | ||||
| TEST(SUITE, ArrayIsLong) { assertIsNot<long>(JsonArray::invalid()); } | ||||
| TEST(SUITE, ArrayIsString) { assertIsNot<const char*>(JsonArray::invalid()); } | ||||
| TEST(SUITE, ArrayIsArry) { | ||||
|   assertIs<JsonArray&>(JsonArray::invalid()); | ||||
| } | ||||
| TEST(SUITE, ArrayIsBool) { | ||||
|   assertIsNot<bool>(JsonArray::invalid()); | ||||
| } | ||||
| TEST(SUITE, ArrayIsDouble) { | ||||
|   assertIsNot<double>(JsonArray::invalid()); | ||||
| } | ||||
| TEST(SUITE, ArrayIsFloat) { | ||||
|   assertIsNot<float>(JsonArray::invalid()); | ||||
| } | ||||
| TEST(SUITE, ArrayIsInt) { | ||||
|   assertIsNot<int>(JsonArray::invalid()); | ||||
| } | ||||
| TEST(SUITE, ArrayIsLong) { | ||||
|   assertIsNot<long>(JsonArray::invalid()); | ||||
| } | ||||
| TEST(SUITE, ArrayIsString) { | ||||
|   assertIsNot<const char*>(JsonArray::invalid()); | ||||
| } | ||||
|  | ||||
| TEST(SUITE, BoolIsArray) { assertIsNot<JsonArray&>(true); } | ||||
| TEST(SUITE, BoolIsBool) { assertIs<bool>(true); } | ||||
| TEST(SUITE, BoolIsDouble) { assertIsNot<double>(true); } | ||||
| TEST(SUITE, BoolIsFloat) { assertIsNot<float>(true); } | ||||
| TEST(SUITE, BoolIsInt) { assertIsNot<int>(true); } | ||||
| TEST(SUITE, BoolIsLong) { assertIsNot<long>(true); } | ||||
| TEST(SUITE, BoolIsString) { assertIsNot<const char*>(true); } | ||||
| TEST(SUITE, BoolIsArray) { | ||||
|   assertIsNot<JsonArray&>(true); | ||||
| } | ||||
| TEST(SUITE, BoolIsBool) { | ||||
|   assertIs<bool>(true); | ||||
| } | ||||
| TEST(SUITE, BoolIsDouble) { | ||||
|   assertIsNot<double>(true); | ||||
| } | ||||
| TEST(SUITE, BoolIsFloat) { | ||||
|   assertIsNot<float>(true); | ||||
| } | ||||
| TEST(SUITE, BoolIsInt) { | ||||
|   assertIsNot<int>(true); | ||||
| } | ||||
| TEST(SUITE, BoolIsLong) { | ||||
|   assertIsNot<long>(true); | ||||
| } | ||||
| TEST(SUITE, BoolIsString) { | ||||
|   assertIsNot<const char*>(true); | ||||
| } | ||||
|  | ||||
| TEST(SUITE, DoubleIsArray) { assertIsNot<JsonArray&>(4.2); } | ||||
| TEST(SUITE, DoubleIsBool) { assertIsNot<bool>(4.2); } | ||||
| TEST(SUITE, DoubleIsDouble) { assertIs<double>(4.2); } | ||||
| TEST(SUITE, DoubleIsFloat) { assertIs<float>(4.2); } | ||||
| TEST(SUITE, DoubleIsInt) { assertIsNot<int>(4.2); } | ||||
| TEST(SUITE, DoubleIsLong) { assertIsNot<long>(4.2); } | ||||
| TEST(SUITE, DoubleIsString) { assertIsNot<const char*>(4.2); } | ||||
| TEST(SUITE, DoubleIsArray) { | ||||
|   assertIsNot<JsonArray&>(4.2); | ||||
| } | ||||
| TEST(SUITE, DoubleIsBool) { | ||||
|   assertIsNot<bool>(4.2); | ||||
| } | ||||
| TEST(SUITE, DoubleIsDouble) { | ||||
|   assertIs<double>(4.2); | ||||
| } | ||||
| TEST(SUITE, DoubleIsFloat) { | ||||
|   assertIs<float>(4.2); | ||||
| } | ||||
| TEST(SUITE, DoubleIsInt) { | ||||
|   assertIsNot<int>(4.2); | ||||
| } | ||||
| TEST(SUITE, DoubleIsLong) { | ||||
|   assertIsNot<long>(4.2); | ||||
| } | ||||
| TEST(SUITE, DoubleIsString) { | ||||
|   assertIsNot<const char*>(4.2); | ||||
| } | ||||
|  | ||||
| TEST(SUITE, LongIsArray) { assertIsNot<JsonArray&>(42L); } | ||||
| TEST(SUITE, LongIsBool) { assertIsNot<bool>(42L); } | ||||
| TEST(SUITE, LongIsDouble) { assertIsNot<double>(42L); } | ||||
| TEST(SUITE, LongIsFloat) { assertIsNot<float>(42L); } | ||||
| TEST(SUITE, LongIsInt) { assertIs<int>(42L); } | ||||
| TEST(SUITE, LongIsLong) { assertIs<long>(42L); } | ||||
| TEST(SUITE, LongIsString) { assertIsNot<const char*>(42L); } | ||||
| TEST(SUITE, LongIsArray) { | ||||
|   assertIsNot<JsonArray&>(42L); | ||||
| } | ||||
| TEST(SUITE, LongIsBool) { | ||||
|   assertIsNot<bool>(42L); | ||||
| } | ||||
| TEST(SUITE, LongIsDouble) { | ||||
|   assertIsNot<double>(42L); | ||||
| } | ||||
| TEST(SUITE, LongIsFloat) { | ||||
|   assertIsNot<float>(42L); | ||||
| } | ||||
| TEST(SUITE, LongIsInt) { | ||||
|   assertIs<int>(42L); | ||||
| } | ||||
| TEST(SUITE, LongIsLong) { | ||||
|   assertIs<long>(42L); | ||||
| } | ||||
| TEST(SUITE, LongIsString) { | ||||
|   assertIsNot<const char*>(42L); | ||||
| } | ||||
|  | ||||
| TEST(SUITE, StringIsArray) { assertIsNot<JsonArray&>("42"); } | ||||
| TEST(SUITE, StringIsBool) { assertIsNot<bool>("42"); } | ||||
| TEST(SUITE, StringIsDouble) { assertIsNot<double>("42"); } | ||||
| TEST(SUITE, StringIsFloat) { assertIsNot<float>("42"); } | ||||
| TEST(SUITE, StringIsInt) { assertIsNot<int>("42"); } | ||||
| TEST(SUITE, StringIsLong) { assertIsNot<long>("42"); } | ||||
| TEST(SUITE, StringIsString) { assertIs<const char*>("42"); } | ||||
| TEST(SUITE, StringIsArray) { | ||||
|   assertIsNot<JsonArray&>("42"); | ||||
| } | ||||
| TEST(SUITE, StringIsBool) { | ||||
|   assertIsNot<bool>("42"); | ||||
| } | ||||
| TEST(SUITE, StringIsDouble) { | ||||
|   assertIsNot<double>("42"); | ||||
| } | ||||
| TEST(SUITE, StringIsFloat) { | ||||
|   assertIsNot<float>("42"); | ||||
| } | ||||
| TEST(SUITE, StringIsInt) { | ||||
|   assertIsNot<int>("42"); | ||||
| } | ||||
| TEST(SUITE, StringIsLong) { | ||||
|   assertIsNot<long>("42"); | ||||
| } | ||||
| TEST(SUITE, StringIsString) { | ||||
|   assertIs<const char*>("42"); | ||||
| } | ||||
|  | ||||
| TEST(SUITE, UnparsedTrueIsArra) { assertIsNot<JsonArray&>(RawJson("true")); } | ||||
| TEST(SUITE, UnparsedTrueIsBool) { assertIs<bool>(RawJson("true")); } | ||||
| TEST(SUITE, UnparsedTrueIsDouble) { assertIsNot<double>(RawJson("true")); } | ||||
| TEST(SUITE, UnparsedTrueIsFloat) { assertIsNot<float>(RawJson("true")); } | ||||
| TEST(SUITE, UnparsedTrueIsInt) { assertIsNot<int>(RawJson("true")); } | ||||
| TEST(SUITE, UnparsedTrueIsLong) { assertIsNot<long>(RawJson("true")); } | ||||
| TEST(SUITE, UnparsedTrueIsString) { assertIsNot<const char*>(RawJson("true")); } | ||||
| TEST(SUITE, UnparsedTrueIsArray) { | ||||
|   assertIsNot<JsonArray&>(RawJson("true")); | ||||
| } | ||||
| TEST(SUITE, UnparsedTrueIsBool) { | ||||
|   assertIs<bool>(RawJson("true")); | ||||
| } | ||||
| TEST(SUITE, UnparsedTrueIsDouble) { | ||||
|   assertIsNot<double>(RawJson("true")); | ||||
| } | ||||
| TEST(SUITE, UnparsedTrueIsFloat) { | ||||
|   assertIsNot<float>(RawJson("true")); | ||||
| } | ||||
| TEST(SUITE, UnparsedTrueIsInt) { | ||||
|   assertIsNot<int>(RawJson("true")); | ||||
| } | ||||
| TEST(SUITE, UnparsedTrueIsLong) { | ||||
|   assertIsNot<long>(RawJson("true")); | ||||
| } | ||||
| TEST(SUITE, UnparsedTrueIsString) { | ||||
|   assertIsNot<const char*>(RawJson("true")); | ||||
| } | ||||
|  | ||||
| TEST(SUITE, UnparsedFalseIsArra) { assertIsNot<JsonArray&>(RawJson("false")); } | ||||
| TEST(SUITE, UnparsedFalseIsBool) { assertIs<bool>(RawJson("false")); } | ||||
| TEST(SUITE, UnparsedFalseIsDouble) { assertIsNot<double>(RawJson("false")); } | ||||
| TEST(SUITE, UnparsedFalseIsFloat) { assertIsNot<float>(RawJson("false")); } | ||||
| TEST(SUITE, UnparsedFalseIsInt) { assertIsNot<int>(RawJson("false")); } | ||||
| TEST(SUITE, UnparsedFalseIsLong) { assertIsNot<long>(RawJson("false")); } | ||||
| TEST(SUITE, UnparsedFalseIsArray) { | ||||
|   assertIsNot<JsonArray&>(RawJson("false")); | ||||
| } | ||||
| TEST(SUITE, UnparsedFalseIsBool) { | ||||
|   assertIs<bool>(RawJson("false")); | ||||
| } | ||||
| TEST(SUITE, UnparsedFalseIsDouble) { | ||||
|   assertIsNot<double>(RawJson("false")); | ||||
| } | ||||
| TEST(SUITE, UnparsedFalseIsFloat) { | ||||
|   assertIsNot<float>(RawJson("false")); | ||||
| } | ||||
| TEST(SUITE, UnparsedFalseIsInt) { | ||||
|   assertIsNot<int>(RawJson("false")); | ||||
| } | ||||
| TEST(SUITE, UnparsedFalseIsLong) { | ||||
|   assertIsNot<long>(RawJson("false")); | ||||
| } | ||||
| TEST(SUITE, UnparsedFalseIsString) { | ||||
|   assertIsNot<const char*>(RawJson("false")); | ||||
| } | ||||
|  | ||||
| TEST(SUITE, UnparsedIntIsArra) { assertIsNot<JsonArray&>(RawJson("42")); } | ||||
| TEST(SUITE, UnparsedIntIsBool) { assertIsNot<bool>(RawJson("42")); } | ||||
| TEST(SUITE, UnparsedIntIsDouble) { assertIsNot<double>(RawJson("42")); } | ||||
| TEST(SUITE, UnparsedIntIsFloat) { assertIsNot<float>(RawJson("42")); } | ||||
| TEST(SUITE, UnparsedIntIsInt) { assertIs<int>(RawJson("42")); } | ||||
| TEST(SUITE, UnparsedIntIsLong) { assertIs<long>(RawJson("42")); } | ||||
| TEST(SUITE, UnparsedIntIsString) { assertIsNot<const char*>(RawJson("42")); } | ||||
| TEST(SUITE, UnparsedIntIsArray) { | ||||
|   assertIsNot<JsonArray&>(RawJson("42")); | ||||
| } | ||||
| TEST(SUITE, UnparsedIntIsBool) { | ||||
|   assertIsNot<bool>(RawJson("42")); | ||||
| } | ||||
| TEST(SUITE, UnparsedIntIsDouble) { | ||||
|   assertIsNot<double>(RawJson("42")); | ||||
| } | ||||
| TEST(SUITE, UnparsedIntIsFloat) { | ||||
|   assertIsNot<float>(RawJson("42")); | ||||
| } | ||||
| TEST(SUITE, UnparsedIntIsInt) { | ||||
|   assertIs<int>(RawJson("42")); | ||||
| } | ||||
| TEST(SUITE, UnparsedIntIsLong) { | ||||
|   assertIs<long>(RawJson("42")); | ||||
| } | ||||
| TEST(SUITE, UnparsedIntIsString) { | ||||
|   assertIsNot<const char*>(RawJson("42")); | ||||
| } | ||||
|  | ||||
| TEST(SUITE, UnparsedFloatIsBool) { assertIsNot<bool>(RawJson("4.2e-10")); } | ||||
| TEST(SUITE, UnparsedFloatIsDouble) { assertIs<double>(RawJson("4.2e-10")); } | ||||
| TEST(SUITE, UnparsedFloatIsFloat) { assertIs<float>(RawJson("4.2e-10")); } | ||||
| TEST(SUITE, UnparsedFloatIsInt) { assertIsNot<int>(RawJson("4.2e-10")); } | ||||
| TEST(SUITE, UnparsedFloatIsLong) { assertIsNot<long>(RawJson("4.2e-10")); } | ||||
| TEST(SUITE, UnparsedFloatIsStr) { assertIsNot<const char*>(RawJson("4.2")); } | ||||
| TEST(SUITE, UnparsedFloatIsBool) { | ||||
|   assertIsNot<bool>(RawJson("4.2e-10")); | ||||
| } | ||||
| TEST(SUITE, UnparsedFloatIsDouble) { | ||||
|   assertIs<double>(RawJson("4.2e-10")); | ||||
| } | ||||
| TEST(SUITE, UnparsedFloatIsFloat) { | ||||
|   assertIs<float>(RawJson("4.2e-10")); | ||||
| } | ||||
| TEST(SUITE, UnparsedFloatIsInt) { | ||||
|   assertIsNot<int>(RawJson("4.2e-10")); | ||||
| } | ||||
| TEST(SUITE, UnparsedFloatIsLong) { | ||||
|   assertIsNot<long>(RawJson("4.2e-10")); | ||||
| } | ||||
| TEST(SUITE, UnparsedFloatIsStr) { | ||||
|   assertIsNot<const char*>(RawJson("4.2")); | ||||
| } | ||||
|  | ||||
| TEST(SUITE, UnparsedNullIsArray) { | ||||
|   assertIsNot<JsonArray&>(RawJson("null")); | ||||
| } | ||||
| TEST(SUITE, UnparsedNullIsBool) { | ||||
|   assertIsNot<bool>(RawJson("null")); | ||||
| } | ||||
| TEST(SUITE, UnparsedNullIsDouble) { | ||||
|   assertIsNot<double>(RawJson("null")); | ||||
| } | ||||
| TEST(SUITE, UnparsedNullIsFloat) { | ||||
|   assertIsNot<float>(RawJson("null")); | ||||
| } | ||||
| TEST(SUITE, UnparsedNullIsInt) { | ||||
|   assertIsNot<int>(RawJson("null")); | ||||
| } | ||||
| TEST(SUITE, UnparsedNullIsLong) { | ||||
|   assertIsNot<long>(RawJson("null")); | ||||
| } | ||||
| TEST(SUITE, UnparsedNullIsConstCharPtr) { | ||||
|   assertIs<const char*>(RawJson("null")); | ||||
| } | ||||
| TEST(SUITE, UnparsedNullIsCharPtr) { | ||||
|   assertIs<char*>(RawJson("null")); | ||||
| } | ||||
|   | ||||
		Reference in New Issue
	
	Block a user