Christopher Haster 1ae4b36f2a Removed unnecessary randomization of offsets in lfs_alloc_reset ...

On first read, randomizing the allocators offset may seem appropriate
for lfs_alloc_reset. However, it ends up using the filesystem-fed
pseudorandom seed in situations it wasn't designed for.

As noted by gtaska, the combination of using xors for feeding the seed
and multiple traverses of the same CRCs can cause the seed to flip to
zeros with concerning frequency.

Removed the randomization from lfs_alloc_reset, leaving it in only
lfs_mount.

Found by gtaska

2020-11-20 00:18:13 -06:00

149 KiB

Raw Blame History

View Raw